On Thu, 13 Jun 2024 at 08:04, Mike Rapoport <rppt@xxxxxxxxxx> wrote: > > On Wed, Jun 12, 2024 at 02:52:28PM -0400, Steven Rostedt wrote: > > On Wed, 12 Jun 2024 11:45:57 -0700 > > Kees Cook <kees@xxxxxxxxxx> wrote: > > > > > On Tue, Jun 11, 2024 at 10:49:13AM -0400, Steven Rostedt wrote: > > > > From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx> > > > > > > > > Add a method to find a region specified by reserve_mem=nn:align:name for > > > > ramoops. Adding a kernel command line parameter: > > > > > > > > reserve_mem=12M:4096:oops ramoops.mem_name=oops > > > > > > > > Will use the size and location defined by the memmap parameter where it > > > > finds the memory and labels it "oops". The "oops" in the ramoops option > > > > is used to search for it. > > > > > > > > This allows for arbitrary RAM to be used for ramoops if it is known that > > > > the memory is not cleared on kernel crashes or soft reboots. > > > > > > > > Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx> > > > > > > Acked-by: Kees Cook <kees@xxxxxxxxxx> > > > > > > Let me know if this should go via the pstore tree, if you'd rather carry > > > it? > > > > > > > I'm going to send out another version to cover some more comments that > > were made, and perhaps it's best if Mike Rapoport takes it through his > > tree. > > I've added one more comment to v5, with that fixed I can take this. > So how is this supposed to work wrt to the rigid 'no user visible regressions' rule, given that this whole thing is a best effort thing to begin with. This needs at least a huge disclaimer that this rule does not apply, and if this works today, there is no guarantee that it will keep working on newer kernels. Otherwise, you will be making the job of the people who work on the boot code significantly more difficult. And even then, I wonder whether Linus and #regzcop are going to honour such a disclaimer. So this belongs downstream, unless some guarantees can be provided that this functionality is exempt from the usual regression policies.
