Re: [PATCH unstable] mm: rmap: abstract updating per-node and per-memcg stats fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12.06.24 07:10, Hugh Dickins wrote:
/proc/meminfo is showing ridiculously large numbers on some lines:
__folio_remove_rmap()'s __folio_mod_stat() should be subtracting!

Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
---
A fix for folding into mm-unstable, not needed for 6.10-rc.

  mm/rmap.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1567,7 +1567,7 @@ static __always_inline void __folio_remove_rmap(struct folio *folio,
  		    list_empty(&folio->_deferred_list))
  			deferred_split_folio(folio);
  	}
-	__folio_mod_stat(folio, nr, nr_pmdmapped);
+	__folio_mod_stat(folio, -nr, -nr_pmdmapped);
/*
  	 * It would be tidy to reset folio_test_anon mapping when fully

Missed that detail, thanks!

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux