On Tue, Jun 11, 2024 at 10:16 AM Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote: > > On Mon, Jun 10, 2024 at 03:30:37PM GMT, Usama Arif wrote: > > start/end writeback combination incorrectly increments NR_WRITTEN > > counter, eventhough the pages aren't written to disk. Pages successfully > > stored in zswap should just unlock folio and return from writepage. > > > > Signed-off-by: Usama Arif <usamaarif642@xxxxxxxxx> > > If Andrew has not picked this up, send a v2 with more detailed commit > message, particularly why it is safe apply this change. You can use the > explanation given by Yosry in response to my email. Also add text > answering the other questions raised by Yosry. > > If Andrew has already picked it up, just request him to update the > commit message. Yes please, thanks Shakeel. I wanted to ask for this but got derailed :) With the updated commit log feel free to add: Acked-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx> > > You can add: > > Reviewed-by: Shakeel Butt <shakeel.butt@xxxxxxxxx> >