Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wei Yang <richard.weiyang@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>
Subject: Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up
From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Tue, 11 Jun 2024 07:58:17 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Lorenzo Stoakes <lstoakes@xxxxxxxxx>, linux-mm@xxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>, linux-hardening@xxxxxxxxxxxxxxx, Ross Zwisler <zwisler@xxxxxxxxxx>, wklin@xxxxxxxxxx, Vineeth Remanan Pillai <vineeth@xxxxxxxxxxxxxxx>, Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>, Suleiman Souhlal <suleiman@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxx>
In-reply-to: <20240611144029.h7egl4aif5mjlrwf@master>
References: <20240606150143.876469296@goodmis.org> <20240606150316.751642266@goodmis.org> <20240611144029.h7egl4aif5mjlrwf@master>
User-agent: Mozilla Thunderbird

On 6/11/24 07:40, Wei Yang wrote:
[ ... ]

+/* Keep a table to reserve named memory */
+#define RESERVE_MEM_MAX_ENTRIES		8
+#define RESERVE_MEM_NAME_SIZE		16

                                         ^
Suggest to align with previous line.

It _is_ aligned. It just looks unaligned because of the "+"
at the beginning of the patch.

Guenter

References:
- [PATCH v2 0/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up
  - From: Steven Rostedt
- [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up
  - From: Steven Rostedt
- Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up
  - From: Wei Yang

Prev by Date: [akpm-mm:mm-unstable 175/198] {standard input}:63: Error: symbol `__export_symbol___totalhigh_pages' is already defined
Next by Date: Re: [PATCH v1 1/3] mm: zswap: fix global shrinker memcg iteration
Previous by thread: Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up
Next by thread: Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]