On Thu, Jul 19, 2012 at 07:23:07PM +0900, Kamezawa Hiroyuki wrote: >(2012/07/19 18:29), Michal Hocko wrote: >>On Wed 18-07-12 19:08:54, Wanpeng Li wrote: >>>use exist interface mem_cgroup_css instead of &mem->css. >> >>This interface has been added to enable mem->css outside of >>mm/memcontrol.c (where we define struct mem_cgroup). There is one user >>left (hwpoison_filter_task) after recent clean ups. >> >>I think we shouldn't spread the usage inside the mm/memcontrol.c. The >>compiler inlines the function for all callers added by this patch but I >>wouldn't rely on it. It is also unfortunate that we cannot convert all >>dereferences (e.g. const mem_cgroup). >>Moreover it doesn't add any additional type safety. So I would vote for >>not taking the patch but if others like it I will not block it. >> > >Agreed. Hmm, I see, thank you. :-) Best Regards, Wanpeng Li > >-Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>