On Fri, May 31, 2024 at 11:33:46PM -0700, Shakeel Butt wrote: > On Tue, May 28, 2024 at 01:20:58PM GMT, Roman Gushchin wrote: > > Cgroup v1's memory controller contains a pretty complicated > > event notifications mechanism which is not used on cgroup v2. > > Let's move the corresponding code into memcontrol-v1.c. > > > > Please, note, that mem_cgroup_event_ratelimit() remains in > > memcontrol.c, otherwise it would require exporting too many > > details on memcg stats outside of memcontrol.c. > > In the followup work, we should decouple v1 only fields from v2 fields > and then we should be able to move mem_cgroup_event_ratelimit() to the > memcontrol-v1.c file. Right, agree, this is my plan. In the RFC version I had a lot of #ifdef's in mm/memcontrol.c and now I plan to do it in a nicer way, moving cgroup v1 - specific stuff into separate functions. Thanks!
