On Tue, 2024-05-28 at 22:05 +0100, Matthew Wilcox wrote: > On Mon, May 27, 2024 at 06:36:07PM +0200, Christoph Hellwig wrote: > > Hi all, > > > > this series adds large folio support to NFS, and almost doubles the > > buffered write throughput from the previous bottleneck of ~2.5GB/s > > (just like for other file systems). > > > > The first patch is an old one from willy that I've updated very > > slightly. > > Note that this update now requires the mapping_max_folio_size > > helper > > merged into Linus' tree only a few minutes ago. > > Kind of surprised this didn't fall over given the bugs I just sent a > patch for ... misinterpreting the folio indices seems like it should > have caused a failure in _some_ fstest. Why wouldn't it work? The code you're replacing isn't assuming that page cache indices are in units of the folio size. It is just assuming that folio boundaries are multiples of the folio size. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
