Re: [PATCH v3 3/5] mm: migrate: support poisoned recover from migrate folio

[Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>]

On 2024/5/29 4:15, Jane Chu wrote:
> > +
> > +    if (unlikely(folio_mc_copy(dst, src))) {
> > +        if (mapping)
> > +            folio_ref_unfreeze(src, expected_cnt);
> > +        return -EFAULT;
> > +    }
>
> Why not return what folio_mc_copy() returns?

The old version has ret of folio_mc_copy(),  but omit it in this
version, no strong option, I could add it back, thanks.

> Similar comment for patch 4/5 as well.
>
> -jane
>
> > +
> > +    __folio_migrate_mapping(mapping, dst, src, expected_cnt);
> >       if (src_private)
> >           folio_attach_private(dst, folio_detach_private(src));
> > -    folio_migrate_copy(dst, src);
> > +    folio_migrate_flags(dst, src);
> >       return MIGRATEPAGE_SUCCESS;
> >   }