On 5/25/24 1:26 AM, Kees Cook wrote: > On Wed, May 22, 2024 at 11:50:37AM +0200, Vlastimil Babka wrote: >> The functions __kmalloc_noprof(), kmalloc_large_noprof(), >> kmalloc_trace_noprof() and their _node variants are all internal to the >> implementations of kmalloc_noprof() and kmalloc_node_noprof() and are >> only declared in the "public" slab.h and exported so that those >> implementations can be static inline and distinguish the build-time >> constant size variants. The only other users for some of the internal >> functions are slub_kunit and fortify_kunit tests which make very >> short-lived allocations. > > If it's only internal, I'm happy to drop it from fortify_kunit. Yeah, looks like you already have static and dynamic size parameter variants of the tests so testing kmalloc() will call __kmalloc_noprof() in the dynamic case (ditto _node variant) and is the best way to exercise that. So So in v2 I will drop those from fortify_kunit instead of adjusting names. > -Kees >
