Christophe Leroy <christophe.leroy@xxxxxxxxxx> writes: > Hi Oscar, hi Michael, > > Le 20/05/2024 à 11:14, Oscar Salvador a écrit : >> On Fri, May 17, 2024 at 09:00:00PM +0200, Christophe Leroy wrote: >>> set_huge_pte_at() expects the real page size, not the psize which is >> >> "expects the size of the huge page" sounds bettter? > > Parameter 'pzize' already provides the size of the hugepage, but not in > the way set_huge_pte_at() expects it. > > psize has one of the values defined by MMU_PAGE_XXX macros defined in > arch/powerpc/include/asm/mmu.h while set_huge_pte_at() expects the size > as a value. > >> >>> the index of the page definition in table mmu_psize_defs[] >>> >>> Fixes: 935d4f0c6dc8 ("mm: hugetlb: add huge page size param to set_huge_pte_at()") >>> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx> >> >> Reviewed-by: Oscar Salvador <osalvador@xxxxxxx> >> >> AFAICS, this fixup is not related to the series, right? (yes, you will >> the parameter later) >> I would have it at the very beginning of the series. > > You are right, I should have submitted it separately. > > Michael can you take it as a fix for 6.10 ? Yeah I can. Does it actually cause a bug at runtime (I assume so)? cheers