On Mon 16-07-12 00:42:37, Hugh Dickins wrote: > Slab poisoning gave me a General Protection Fault on the > atomic_dec(&__task_cred(p)->user->processes); > line of release_task() called from wait_task_zombie(), > every time my dd to USB testing generated a memcg OOM. Just curious, was it with the wait-on-pagereclaim patch? > oom_kill_process() now does the put_task_struct(), > mem_cgroup_out_of_memory() should not repeat it. Good catch. I have missed that during review - my bad... > > Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx> Acked-by: Michal Hocko <mhocko@xxxxxxx> > --- > > mm/memcontrol.c | 1 - > 1 file changed, 1 deletion(-) > > --- mmotm/mm/memcontrol.c 2012-07-11 14:50:29.808349013 -0700 > +++ linux/mm/memcontrol.c 2012-07-15 12:21:26.234289161 -0700 > @@ -1533,7 +1533,6 @@ void mem_cgroup_out_of_memory(struct mem > points = chosen_points * 1000 / totalpages; > oom_kill_process(chosen, gfp_mask, order, points, totalpages, memcg, > NULL, "Memory cgroup out of memory"); > - put_task_struct(chosen); > } > > static unsigned long mem_cgroup_reclaim(struct mem_cgroup *memcg, > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>