Re: [PATCH] mm: refactor folio_undo_large_rmappable()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2024/5/16 23:54, Vishal Moola wrote:
On Wed, May 15, 2024 at 02:45:06PM +0800, Kefeng Wang wrote:
All folio_undo_large_rmappable() callers will check folio_test_large()
which already checked by folio_order(), so only add the check

This commit message is a little misleading. The folio_order() check in
folio_undo_large_rmappable() is primarily for catching order-1 folios,
not to check folio_test_large(). You can read more about it in
commit: 8897277acfef7f70fdecc.

folio_order <=1 cover the small folio and order=1 cases, maybe I could update message to try to make it clearer,


Aside from that, I like the patch. It should make this code easier to
maintain.

Thanks.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux