On Thu, 12 Jul 2012 17:31:50 -0700 Michel Lespinasse <walken@xxxxxxxxxx> wrote: > This small module helps measure the performance of rbtree insert and erase. > > Additionally, we run a few correctness tests to check that the rbtrees have > all desired properties: > - contains the right number of nodes in the order desired, > - never two consecutive red nodes on any path, > - all paths to leaf nodes have the same number of black nodes, > - root node is black > > Signed-off-by: Michel Lespinasse <walken@xxxxxxxxxx> > --- > Makefile | 2 +- > lib/Kconfig.debug | 1 + > tests/Kconfig | 18 +++++++ > tests/Makefile | 1 + > tests/rbtree_test.c | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++ This patch does a new thing: adds a kernel self-test module into lib/tests/ and sets up the infrastructure to add new kernel self-test modules in that directory. I don't see a problem with this per-se, but it is a new thing which we should think about. In previous such cases (eg, kernel/rcutorture.c) we put those modules into the same directory as the code which is being tested. So to follow that pattern, this new code would have gone into lib/. If we adopt your new proposal then we should perhaps also move tests such as rcutorture over into tests/. And that makes one wonder whether we should have a standalone directory for kernel selftest modules. eg tests/self-test-nmodules/. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>