Hi Andrew,
On Wed, May 08, 2024 at 11:10:07AM -0700, Andrew Morton wrote:
> On Wed, 8 May 2024 11:45:07 +0200 Petr Malat <oss@xxxxxxxxx> wrote:
>
> > Extend page_owner_sort filtering and culling features to work with module
> > names as well. The top most module is used.
>
> I'm not sure what this means. Perhaps providing some sample output
> would be helpful.
page_owner_sort -m --cull module generates output like this:
412434 times, 509515 pages, module: vmlinux
56476 times, 325647 pages, module: rvu_nicpf
4226 times, 4581 pages, module: nfsd
2061 times, 2062 pages, module: mvcpss
278 times, 874 pages, module: rvu_nicvf
125 times, 854 pages, module: mmc_block
473 times, 638 pages, module: dtbo_loader
126 times, 588 pages, module: rvu_af
185 times, 362 pages, module: rvu_cptvf
74 times, 340 pages, module: clk_port
...
where one can see how much memory was allocated by every module,
for example rvu_nicpf (ethernet) allocated 325647 pages in total.
>
> > Fix regex error handling, failure labels were one step shifted.
>
> Again, showing us the before and after effects would aid understanding.
According to the regfree manual page, regfree takes "precompiled pattern
buffer" as its argument, so if regcomp(preg, pattern, flags) fails,
regfree(preg) should not be called, because preg doesn't contain "precompiled
pattern buffer".
BR,
Petr
