on 5/2/2024 12:56 AM, Tejun Heo wrote: > Hello, > > On Mon, Apr 29, 2024 at 11:47:32AM +0800, Kemeng Shi wrote: >> Use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh to remove >> repeated code. > > Maybe fold this into the patch to factor out domain_dirty_avail()? > >> + global_domain_dirty_avail(&gdtc, false); >> + wb_domain_dirty_avail(&mdtc, false); > > I'd just use domain_dirty_avail(). The compiler should be able to figure out > the branches and eliminate them and it removes an unnecessary source of > error. Sure, will this do this in next version. Thanks. > > Thanks. >
