On Sat, May 04, 2024 at 03:44:55PM -0700, Andrew Morton wrote: > +++ a/kernel/watchdog_perf.c > @@ -277,6 +277,8 @@ int __init watchdog_hardlockup_probe(voi > > /** > * hardlockup_config_perf_event - Overwrite config of wd_hw_attr. > + * > + * @str: number which identifies the raw perf event to use > */ > void __init hardlockup_config_perf_event(const char *str) We don't usually put a blank line between the name of the function and the arguments, but other than that, looks good.