Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Chris Li <chrisl@xxxxxxxxxx>
Subject: Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 3 May 2024 21:03:44 -0700
Cc: Ryan Roberts <ryan.roberts@xxxxxxx>, Barry Song <21cnbao@xxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, baolin.wang@xxxxxxxxxxxxxxxxx, david@xxxxxxxxxx, hanchuanhua@xxxxxxxx, hannes@xxxxxxxxxxx, hughd@xxxxxxxxxx, kasong@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, surenb@xxxxxxxxxx, v-songbaohua@xxxxxxxx, willy@xxxxxxxxxxxxx, xiang@xxxxxxxxxx, ying.huang@xxxxxxxxx, yosryahmed@xxxxxxxxxx, yuzhao@xxxxxxxxxx, ziy@xxxxxxxxxx, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Len Brown <len.brown@xxxxxxxxx>
In-reply-to: <CANeU7QkYXmpmTAVjGqin4Wpg9hydPPYZKho-MwQMMt9uJ8Lu4Q@mail.gmail.com>
References: <20240503005023.174597-1-21cnbao@gmail.com> <20240503005023.174597-3-21cnbao@gmail.com> <e0c1cbb2-da06-4658-a23a-962496e83557@arm.com> <CANeU7QkYXmpmTAVjGqin4Wpg9hydPPYZKho-MwQMMt9uJ8Lu4Q@mail.gmail.com>

On Fri, May 03, 2024 at 01:37:06PM -0700, Chris Li wrote:
> Either way works. It will produce the same machine code. I have a
> slight inclination to just drop swap_free(entry) API so that it
> discourages the caller to do a for loop over swap_free().

Then just ad the number of entries parameter to swap_free and do away
with the separate swap_free_nr.

Follow-Ups:
- Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()
  - From: Barry Song

References:
- [PATCH v3 0/6] large folios swap-in: handle refault cases first
  - From: Barry Song
- [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()
  - From: Barry Song
- Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()
  - From: Ryan Roberts
- Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()
  - From: Chris Li

Prev by Date: [PATCH] selftests/exec: build with -fPIE instead of -pie, to make clang happy
Next by Date: Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()
Previous by thread: Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()
Next by thread: Re: [PATCH v3 2/6] mm: remove swap_free() and always use swap_free_nr()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]