Re: [PATCH v2 01/10] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2024/4/27 11:57, kernel test robot wrote:
Hi Kefeng,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm-memory_hotplug-check-hwpoisoned-page-firstly-in-do_migrate_range/20240425-164317
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240425084028.3888403-2-wangkefeng.wang%40huawei.com
patch subject: [PATCH v2 01/10] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range()
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240427/202404271110.2fxPtHNB-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240427/202404271110.2fxPtHNB-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404271110.2fxPtHNB-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

    mm/memory_hotplug.c: In function 'isolate_and_unmap_hwposion_folio':
    mm/memory_hotplug.c:1786:27: error: implicit declaration of function 'hugetlb_page_mapping_lock_write'; did you mean 'hugetlb_folio_mapping_lock_write'? [-Werror=implicit-function-declaration]
     1786 |                 mapping = hugetlb_page_mapping_lock_write(&folio->page);
          |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          |                           hugetlb_folio_mapping_lock_write
mm/memory_hotplug.c:1786:25: warning: assignment to 'struct address_space *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     1786 |                 mapping = hugetlb_page_mapping_lock_write(&folio->page);
          |                         ^
    cc1: some warnings being treated as errors


The patch based on next-20240425, but from next-20240426 with
"mm: convert hugetlb_page_mapping_lock_write to folio", so it is easy to
fix by converting to hugetlb_folio_mapping_lock_write() api, but keep it
for a while, see if there are any new comments about this patchset.


Thanks.



vim +1786 mm/memory_hotplug.c

   1774	
   1775	static bool isolate_and_unmap_hwposion_folio(struct folio *folio)
   1776	{
   1777		if (WARN_ON(folio_test_lru(folio)))
   1778			folio_isolate_lru(folio);
   1779	
   1780		if (!folio_mapped(folio))
   1781			return true;
   1782	
   1783		if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) {
   1784			struct address_space *mapping;
   1785	
1786			mapping = hugetlb_page_mapping_lock_write(&folio->page);
   1787			if (mapping) {
   1788				/*
   1789				 * In shared mappings, try_to_unmap could potentially
   1790				 * call huge_pmd_unshare.  Because of this, take
   1791				 * semaphore in write mode here and set TTU_RMAP_LOCKED
   1792				 * to let lower levels know we have taken the lock.
   1793				 */
   1794				try_to_unmap(folio, TTU_IGNORE_MLOCK | TTU_RMAP_LOCKED);
   1795				i_mmap_unlock_write(mapping);
   1796			}
   1797		} else {
   1798			try_to_unmap(folio, TTU_IGNORE_MLOCK);
   1799		}
   1800	
   1801		return folio_mapped(folio);
   1802	}
   1803	





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux