On Mon, Jul 09, 2012 at 03:46:53PM -0700, Hugh Dickins wrote: > shmem_add_to_page_cache() has three callsites, but only one of them > wants the radix_tree_preload() (an exceptional entry guarantees that > the radix tree node is present in the other cases), and only that site > can achieve mem_cgroup_uncharge_cache_page() (PageSwapCache makes it a > no-op in the other cases). We did it this way originally to reflect > add_to_page_cache_locked(); but it's confusing now, so move the > radix_tree preloading and mem_cgroup uncharging to that one caller. > > Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx> > Cc: Johannes Weiner <hannes@xxxxxxxxxxx> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Cc: Michal Hocko <mhocko@xxxxxxx> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> I'm rebasing my (un)charge series on top of these, thanks. It only annihilates 3/11 and leaves the rest alone--line numbers aside--since the rules did not change. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>