On 25/04/2024 08:37, Kefeng Wang wrote: > > > On 2024/4/25 15:22, David Hildenbrand wrote: >> On 25.04.24 09:18, Kefeng Wang wrote: >>> >>> >>> On 2024/4/25 12:00, Matthew Wilcox wrote: >>>> On Thu, Apr 25, 2024 at 11:51:08AM +0800, Kefeng Wang wrote: >>>>> There are too many bool arguments in thp_vma_allowable_orders(), adding >>>>> some more readable thp_vma_allowable_order_foo(), >>>> >>>> Here's an alternative approach I came up with and forgot to send out. >>>> I take no position on which is better. >>> >>> Always confuse, either way is fine, even combine the two way, let's see >>> Ryan/David's option. >> >> It's shocking how Willy and I sometimes create almost identical patches ;) >> > :) >> I played with the same flags idea during mTHP bringup. >> >> And I think I prefer the flags version. Yeah, FWIW, I prefer the flags approach too. >> > OK, wait for Andrew to pick it
