Re: [PATCH] mm: add more readable thp_vma_allowable_order_foo()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24.04.24 16:07, Kefeng Wang wrote:
There are too many bool arguments in thp_vma_allowable_orders(), adding
some more readable thp_vma_allowable_order_foo(),

Good, I had something similar in mind when talking about that with Ryan in the past (during mTHP development).


   thp_vma_allowable_orders_insmaps() is used in samps
   thp_vma_allowable_order[s]_inpf()  is used in page fault
   thp_vma_allowable_pmd_order_inhuge is used in khugepaged scan and madvise

I really don't like the "_in" stuff. And "inhuge" doesn't add any clarity.

What about

thp_vma_allowable_orders_smaps()
thp_vma_allowable_order[s]_pf()
thp_vma_allowable_pmd_order()

--
Cheers,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux