On Thu, Apr 18, 2024 at 01:55:28PM +1200, Barry Song wrote: > I also find it rather odd that folio_file_page() is utilized for both > swp and file. > > mm/memory.c <<do_swap_page>> > page = folio_file_page(folio, swp_offset(entry)); > mm/swap_state.c <<swapin_readahead>> > return folio_file_page(folio, swp_offset(entry)); > mm/swapfile.c <<unuse_pte>> > page = folio_file_page(folio, swp_offset(entry)); > > Do you believe it's worthwhile to tidy up? Why do you find it odd? What would you propose instead?
