On Wed, Apr 17, 2024 at 02:51:48PM -0400, Pasha Tatashin wrote: > This breaks linux-next build: > > mm/page_table_check.c: In function ‘swap_cached_writable’: > mm/page_table_check.c:192:24: error: ‘SWP_DEVICE_EXCLUSIVE_WRITE’ > undeclared (first use in this function) > 192 | return type == SWP_DEVICE_EXCLUSIVE_WRITE || > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/page_table_check.c:192:24: note: each undeclared identifier is > reported only once for each function it appears in > mm/page_table_check.c:194:1: error: control reaches end of non-void > function [-Werror=return-type] > 194 | } > > Looks like there is a dependence on CONFIG_DEVICE_PRIVATE. Right, same to SWP_MIGRATION_WRITE. I've already sent a v2 with everything fixed, please have a look. I also added one more device private entry type that I overlooked. Thanks, -- Peter Xu