codetag_register_type() never returns NULL, yet IS_ERR_OR_NULL() is used to check its return value. This leads to a warning about possibility of passing NULL to PTR_ERR(). Fix that by using IS_ERR() to exclude NULL. Fixes: 6e8a230a6b1a ("lib: add allocation tagging support for memory allocation profiling") Reported-by: kernel test robot <lkp@xxxxxxxxx> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Closes: https://lore.kernel.org/r/202404051340.7Wo7oiJ5-lkp@xxxxxxxxx/ Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> --- lib/alloc_tag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index b37e3430ed92..26af9982ddc4 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -233,7 +233,7 @@ static int __init alloc_tag_init(void) }; alloc_tag_cttype = codetag_register_type(&desc); - if (IS_ERR_OR_NULL(alloc_tag_cttype)) + if (IS_ERR(alloc_tag_cttype)) return PTR_ERR(alloc_tag_cttype); if (!mem_profiling_support) base-commit: 6723e3b1a668df6b8f305dea8fb62789155d965f -- 2.44.0.769.g3c40516874-goog