From: Wanpeng Li <liwp@xxxxxxxxxxxxxxxxxx> Code was duplicated in two functions, clean it up. Signed-off-by: Wanpeng Li <liwp.linux@xxxxxxxxx> --- mm/hugetlb.c | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index e198831..4f9ce3f 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2282,30 +2282,28 @@ nomem: return -ENOMEM; } -static int is_hugetlb_entry_migration(pte_t pte) +static int is_hugetlb_entry_migration_or_hwpoison(pte_t pte, bool migration) { swp_entry_t swp; if (huge_pte_none(pte) || pte_present(pte)) return 0; swp = pte_to_swp_entry(pte); - if (non_swap_entry(swp) && is_migration_entry(swp)) + if (non_swap_entry(pte) && ((migration && is_migration_entry(pte)) + || !migration && is_hwpoison_entry(pte))) return 1; else return 0; } -static int is_hugetlb_entry_hwpoisoned(pte_t pte) +static int is_hugetlb_entry_migration(pte_t pte) { - swp_entry_t swp; + return is_hugetlb_entry_migration_or_hwpoison(pte, true); +} - if (huge_pte_none(pte) || pte_present(pte)) - return 0; - swp = pte_to_swp_entry(pte); - if (non_swap_entry(swp) && is_hwpoison_entry(swp)) - return 1; - else - return 0; +static int is_hugetlb_entry_hwpoisoned(pte_t pte) +{ + return is_hugetlb_entry_migration_or_hwpoison(pte, false); } void __unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start, -- 1.7.5.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>