2012/7/7 Minchan Kim <minchan@xxxxxxxxxx>: > Hi Joonsoo, > > On Sat, Jul 07, 2012 at 12:28:41AM +0900, Joonsoo Kim wrote: >> __alloc_pages_direct_compact has many arguments so invoking it is very costly. > > It's already slow path so it's pointless for such optimization. I know this is so minor optimization. But why don't we do such a one? Is there any weak point? >> And in almost invoking case, order is 0, so return immediately. > > You can't make sure it. Okay. >> >> Let's not invoke it when order 0 > > Let's not ruin git blame. Hmm... When I do git blame, I can't find anything related to this. Thanks for comments. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>