On Thu, Apr 04, 2024 at 02:07:45PM -0700, Suren Baghdasaryan wrote: > Yes, I was typing my reply :) > This might have happened simply because lock_vma_under_rcu() was > originally developed to handle only anonymous page faults and then got > expanded to cover file-backed cases as well. Your suggestion seems > fine to me but I would feel much more comfortable after Matthew (who > added file-backed support) reviewed it. Thanks. Just in case this will fall through the cracks (while I still think we should do it..), I sent a formal patch just now with some more information in the commit log. Any further review comments welcomed there. -- Peter Xu