On Fri, Jul 06, 2012 at 10:22:42AM +0200, Johannes Weiner wrote: >On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: >> From: Wanpeng Li <liwp@xxxxxxxxxxxxxxxxxx> >> >> Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. > >And nobody is passing anything else. Which is easy to prove as this >is a private function. And there wouldn't even be any harm passing >something else. Please don't add stuff like this. Ok, thank you for your comment. I also have another two patches, title: clarify type in memory cgroups return -EBUSY when oom-kill-disable modified and memcg use_hierarchy, has children Hopefully, you can review. Thank you Johannes! :-) Regards, Wanpeng Li -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>