Re: [PATCH v2 09/11] mm/memory-failure: Add some folio conversions to unpoison_memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/8/2024 12:42 PM, Matthew Wilcox (Oracle) wrote:

Some of these folio APIs didn't exist when the unpoison_memory()
conversion was done originally.

Acked-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
---
  mm/memory-failure.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index fae0b42f0aaf..7caec2fc3327 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2540,8 +2540,8 @@ int unpoison_memory(unsigned long pfn)
  		goto unlock_mutex;
  	}
- if (folio_test_slab(folio) || PageTable(&folio->page) ||
-	    folio_test_reserved(folio) || PageOffline(&folio->page))
+	if (folio_test_slab(folio) || folio_test_pgtable(folio) ||
+	    folio_test_reserved(folio) || folio_test_offline(folio))
  		goto unlock_mutex;
/*
@@ -2562,7 +2562,7 @@ int unpoison_memory(unsigned long pfn)
ghp = get_hwpoison_page(p, MF_UNPOISON);
  	if (!ghp) {
-		if (PageHuge(p)) {
+		if (folio_test_hugetlb(folio)) {
  			huge = true;
  			count = folio_free_raw_hwp(folio, false);
  			if (count == 0)
@@ -2578,7 +2578,7 @@ int unpoison_memory(unsigned long pfn)
  					 pfn, &unpoison_rs);
  		}
  	} else {
-		if (PageHuge(p)) {
+		if (folio_test_hugetlb(folio)) {
  			huge = true;
  			count = folio_free_raw_hwp(folio, false);
  			if (count == 0) {

Looks good.

Reviewed-by: Jane Chu <jane.chu@xxxxxxxxxx>

-jane





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux