Re: [PATCH 7/7] khugepaged: Use a folio throughout hpage_collapse_scan_file()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03.04.24 19:18, Matthew Wilcox (Oracle) wrote:
Replace the use of pages with folios.  Saves a few calls to
compound_head() and removes some uses of obsolete functions.

Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
---

[...]

- if (page_count(page) !=
-		    1 + page_mapcount(page) + page_has_private(page)) {
+		if (folio_ref_count(folio) !=
+		    1 + folio_mapcount(folio) + folio_test_private(folio)) {
  			result = SCAN_PAGE_COUNT;

Just stumbled over that: page_has_private() would have checked PG_private and PG_private_2. The corresponding replacement would have been folio_has_private(). folio_test_private() only checks PG_private.

Are we sure that we no longer have to check PG_private_2 here? pagecache ... so I have no clue :)

--
Cheers,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux