The initial idea comes from Cong Wang. We're running out of memory while calling function skip_free_areas_node(). So it would be unsafe to allocate more memory from either stack or heap. The patche adds more comments to address that. Signed-off-by: Gavin Shan <shangw@xxxxxxxxxxxxxxxxxx> --- mm/page_alloc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 4403009..c74f5a9 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2737,6 +2737,9 @@ void si_meminfo_node(struct sysinfo *val, int nid) /* * Determine whether the node should be displayed or not, depending on whether * SHOW_MEM_FILTER_NODES was passed to show_free_areas(). + * + * We're running out of memory while calling the function. So don't allocate + * more memory from either stack or heap. */ bool skip_free_areas_node(unsigned int flags, int nid) { -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>