On Wed, Apr 03, 2024 at 06:18:31PM +0100, Matthew Wilcox (Oracle) wrote: > @@ -1789,7 +1789,7 @@ static int collapse_file(struct mm_struct *mm, unsigned long addr, > struct page *hpage; > struct page *page; > struct page *tmp; > - struct folio *folio; > + struct folio *folio, *new_folio; Would it make more sense to introduce new_folio in patch 5 where you convert the rest of the function to use new_folio? I think it might make the commit history easier to read.
