Hi Yosry, kernel test robot noticed the following build warnings: [auto build test WARNING on akpm-mm/mm-everything] [also build test WARNING on next-20240405] [cannot apply to linus/master v6.9-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-zswap-always-shrink-in-zswap_store-if-zswap_pool_reached_full/20240405-133623 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240405053510.1948982-3-yosryahmed%40google.com patch subject: [PATCH v2 2/5] mm: zswap: calculate limits only when updated config: i386-randconfig-061-20240405 (https://download.01.org/0day-ci/archive/20240406/202404060445.zMPxumi9-lkp@xxxxxxxxx/config) compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240406/202404060445.zMPxumi9-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202404060445.zMPxumi9-lkp@xxxxxxxxx/ sparse warnings: (new ones prefixed by >>) >> mm/zswap.c:132:15: sparse: sparse: symbol 'zswap_accept_thr_pages' was not declared. Should it be static? mm/zswap.c:1188:23: sparse: sparse: context imbalance in 'shrink_memcg_cb' - unexpected unlock vim +/zswap_accept_thr_pages +132 mm/zswap.c 120 121 static int zswap_max_pool_param_set(const char *, 122 const struct kernel_param *); 123 static const struct kernel_param_ops zswap_max_pool_param_ops = { 124 .set = zswap_max_pool_param_set, 125 .get = param_get_uint, 126 }; 127 module_param_cb(max_pool_percent, &zswap_max_pool_param_ops, 128 &zswap_max_pool_percent, 0644); 129 130 /* The threshold for accepting new pages after the max_pool_percent was hit */ 131 static unsigned int zswap_accept_thr_percent = 90; /* of max pool size */ > 132 unsigned long zswap_accept_thr_pages; 133 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki