Re: [PATCH v4 4/4] rust: add abstraction for `struct page`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Benno Lossin <benno.lossin@xxxxxxxxx>
Subject: Re: [PATCH v4 4/4] rust: add abstraction for `struct page`
From: Alice Ryhl <aliceryhl@xxxxxxxxxx>
Date: Fri, 5 Apr 2024 09:44:06 +0200
Cc: Miguel Ojeda <ojeda@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Alex Gaynor <alex.gaynor@xxxxxxxxx>, Wedson Almeida Filho <wedsonaf@xxxxxxxxx>, Boqun Feng <boqun.feng@xxxxxxxxx>, Gary Guo <gary@xxxxxxxxxxx>, Björn Roy Baron <bjorn3_gh@xxxxxxxxxxxxxx>, Andreas Hindborg <a.hindborg@xxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Arve Hjønnevåg <arve@xxxxxxxxxxx>, Todd Kjos <tkjos@xxxxxxxxxxx>, Martijn Coenen <maco@xxxxxxxxxxx>, Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>, Carlos Llamas <cmllamas@xxxxxxxxxx>, Suren Baghdasaryan <surenb@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, rust-for-linux@xxxxxxxxxxxxxxx, Christian Brauner <brauner@xxxxxxxxxx>
In-reply-to: <a48b2347-b58b-432e-bdb8-d5449016ab57@proton.me>
References: <20240404-alice-mm-v4-0-49a84242cf02@google.com> <20240404-alice-mm-v4-4-49a84242cf02@google.com> <a48b2347-b58b-432e-bdb8-d5449016ab57@proton.me>

On Fri, Apr 5, 2024 at 12:33 AM Benno Lossin <benno.lossin@xxxxxxxxx> wrote:
>
> On 04.04.24 14:31, Alice Ryhl wrote:
> > +/// A bitwise shift for the page size.
> > +#[allow(clippy::unnecessary_cast)]
>
> Why can't you remove the cast?

Bindgen could decide to use a different type in the future or on
different platforms.

Alice

Follow-Ups:
- Re: [PATCH v4 4/4] rust: add abstraction for `struct page`
  - From: Benno Lossin

References:
- [PATCH v4 0/4] Memory management patches needed by Rust Binder
  - From: Alice Ryhl
- [PATCH v4 4/4] rust: add abstraction for `struct page`
  - From: Alice Ryhl
- Re: [PATCH v4 4/4] rust: add abstraction for `struct page`
  - From: Benno Lossin

Prev by Date: Re: [PATCH v3 14/14] mm/ksm: remove set_page_stable_node
Next by Date: Re: [PATCH 3/7] crypto: Remove the now superfluous sentinel element from ctl_table array
Previous by thread: Re: [PATCH v4 4/4] rust: add abstraction for `struct page`
Next by thread: Re: [PATCH v4 4/4] rust: add abstraction for `struct page`
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]