On Fri, Apr 05, 2024 at 01:35:45AM +0000, Yosry Ahmed wrote: > Currently, zswap_store() checks zswap_same_filled_pages_enabled, kmaps > the folio, then calls zswap_is_page_same_filled() to check the folio > contents. Move this logic into zswap_is_page_same_filled() as well (and > rename it to use 'folio' while we are at it). > > This makes zswap_store() cleaner, and makes following changes to that > logic contained within the helper. While we are at it, rename the > insert_entry label to store_entry to match xa_store(). > > No functional change intended. > > Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx> > Reviewed-by: Nhat Pham <nphamcs@xxxxxxxxx> > Reviewed-by: Chengming Zhou <chengming.zhou@xxxxxxxxx> Nice one. Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>