On Thu, Apr 04, 2024 at 11:36:07PM +0000, Wei Yang wrote: >The dummy entry is introduced in the initial implementation of lmb in >commit 7c8c6b9776fb ("powerpc: Merge lmb.c and make MM initialization >use it."). > >As the comment says the empty dummy entry is to simplify the code. > > /* Create a dummy zero size LMB which will get coalesced away later. > * This simplifies the lmb_add() code below... > */ > >While current code is reimplemented by Tejun in commit 784656f9c680 >("memblock: Reimplement memblock_add_region()"). This empty dummy entry >seems not benefit the code any more. > >Let's remove it. > >Signed-off-by: Wei Yang <richard.weiyang@xxxxxxxxx> >CC: Paul Mackerras <paulus@xxxxxxxxxx> >CC: Tejun Heo <tj@xxxxxxxxxx> >CC: Mike Rapoport <rppt@xxxxxxxxxx> > >--- >v2: remove cnt initialization to 0 and keep special case for empty array Sorry for the quick hand. Please ignore this one. -- Wei Yang Help you, Help me