On Thu, Mar 28, 2024 at 12:36:30PM -0700, Svetly Todorov wrote: > The fix for this particular file looks good, > but some other architectures still use page->flags > to test/set PG_arch_1 aliases: > > ./arch/arc/include/asm/cacheflush.h:#define PG_dc_clean PG_arch_1 > ./arch/arm/include/asm/cacheflush.h:#define PG_dcache_clean PG_arch_1 > ./arch/arm64/include/asm/cacheflush.h:#define PG_dcache_clean PG_arch_1 > > (in arch): grep -rI . -e 'page->flags' > > ./s390/include/asm/hugetlb.h: clear_bit(PG_arch_1, &page->flags); > ./s390/mm/hugetlbpage.c: if (!test_and_set_bit(PG_arch_1, &page->flags)) > ./sh/include/asm/hugetlb.h: clear_bit(PG_dcache_clean, &page->flags); > ./sh/mm/cache-sh4.c: test_bit(PG_dcache_clean, &page->flags) && Fixed elsewhere in this patch series. > ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); > ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); > ./s390/kernel/uv.c: set_bit(PG_arch_1, &page->flags); > ./s390/kernel/uv.c: if (!test_bit(PG_arch_1, &page->flags)) > ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); > ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); > ./s390/mm/gmap.c: set_bit(PG_arch_1, &page->flags); > > ... (not an exhaustive list) ... s390 is a disaster area for use of page->flags. I've sent patches with no response or "we can't do that" responses. I'm ignoring them until I get more useful responses. > But at least for xtensa, this LGTM. > > Reviewed-by: Svetly Todorov <svetly.todorov@xxxxxxxxxxxx> Thanks.
