On Thu, 28 Mar 2024 15:15:03 -0400 Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote: > On Wed, Mar 27, 2024 at 10:40:10AM -0700, Andrew Morton wrote: > > On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> wrote: > > > > > This series tries to improve visilibity of writeback. > > > > Well... why? Is anyone usefully using the existing instrumentation? > > What is to be gained by expanding it further? What is the case for > > adding this code? > > > > I don't recall hearing of anyone using the existing debug > > instrumentation so perhaps we should remove it! > > Remove debug instrumentation!? Surely you just? Absolutely not. Any code in the kernel should have ongoing justification for remaining there. If no such justification exists, out it goes.