Hi Rik, On Fri, Jun 29, 2012 at 10:26:39AM -0400, Rik van Riel wrote: > On 06/28/2012 08:55 AM, Andrea Arcangeli wrote: > > > +/* > > + * Cannot be set on pte. The fact it's in between _PAGE_FILE and > > + * _PAGE_PROTNONE avoids having to alter the swp entries. > > + */ > > +#define _PAGE_NUMA_PTE _PAGE_PSE > > +/* > > + * Cannot be set on pmd, if transparent hugepages will be swapped out > > + * the swap entry offset must start above it. > > + */ > > +#define _PAGE_NUMA_PMD _PAGE_UNUSED2 > > Those comments only tell us what the flags can NOT be > used for, not what they are actually used for. You can find an updated version of the comments here: http://git.kernel.org/?p=linux/kernel/git/andrea/aa.git;a=commitdiff;h=927ca960d78fefe6fa6aaa260a5b35496abafec5 Thanks for all the feedback, I didn't reply immediately but I'm handling all the feedback and many more bits have been improved already in the autonuma branch. I will post them separately for further review. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>