On 3/22/24 11:57 PM, Matthew Wilcox wrote: > On Fri, Mar 22, 2024 at 04:36:52PM +0800, alexs@xxxxxxxxxx wrote: >> -static struct page *stable_node_dup(struct ksm_stable_node **_stable_node_dup, >> - struct ksm_stable_node **_stable_node, >> - struct rb_root *root, >> - bool prune_stale_stable_nodes) >> +static void *stable_node_dup(struct ksm_stable_node **_stable_node_dup, >> + struct ksm_stable_node **_stable_node, >> + struct rb_root *root, >> + bool prune_stale_stable_nodes) > > Do we really have to go through this void * stage? Hi Willy, Thank a lot for reminder. Yes, we could keep the 'struct page*' return value here. And so we don't need to change indent here. Thanks! > > Also, please stop reindenting the arguments. I tend to just switch to > two tabs, but lining them up with the opening bracket leads to extra > churn. Either leave them alone for the entire series or switch _once_. >
