(2012/06/28 20:05), Sha Zhengju wrote: > From: Sha Zhengju <handai.szj@xxxxxxxxxx> > > Similar to dirty page, we add per cgroup writeback pages accounting. The lock > rule still is: > mem_cgroup_begin_update_page_stat() > modify page WRITEBACK stat > mem_cgroup_update_page_stat() > mem_cgroup_end_update_page_stat() > > There're two writeback interface to modify: test_clear/set_page_writeback. > > Signed-off-by: Sha Zhengju <handai.szj@xxxxxxxxxx> Seems good to me. BTW, you named macros as MEM_CGROUP_STAT_FILE_XXX but I wonder these counters will be used for accounting swap-out's dirty pages.. STAT_DIRTY, STAT_WRITEBACK ? do you have better name ? Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>