Re: [linux-next:master 13900/14187] drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret'

[Helge Deller <deller@xxxxxx>]

On 3/22/24 03:54, Zhijian Li (Fujitsu) wrote:
> Helge
>
> Should I send a new version(v4) to fix this.

No, it's ok.
I've fixed it up already.

Thanks!
Helge

> Thanks
> Zhijian
>
> On 21/03/2024 19:56, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   e7528c088874326d3060a46f572252be43755a86
> > commit: 0688d3b1d882dd1dcf73305306e71ebf1653f595 [13900/14187] fbdev: panel-tpo-td043mtea1: Convert sprintf() to sysfs_emit()
> > config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@xxxxxxxxx/config)
> > compiler: sh4-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@xxxxxxxxx/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202403211931.wVl6ymAV-lkp@xxxxxxxxx/
> >
> > All warnings (new ones prefixed by >>):
> >
> >      drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c: In function 'tpo_td043_gamma_show':
> > > > drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret' [-Wunused-variable]
> >        228 |         int ret;
> >            |             ^~~
> >
> >
> > vim +/ret +228 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
> >
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  222
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  223  static ssize_t tpo_td043_gamma_show(struct device *dev,
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  224  	struct device_attribute *attr, char *buf)
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  225  {
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  226  	struct panel_drv_data *ddata = dev_get_drvdata(dev);
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  227  	ssize_t len = 0;
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09 @228  	int ret;
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  229  	int i;
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  230
> > 0688d3b1d882dd Li Zhijian     2024-03-19  231  	for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++)
> > 0688d3b1d882dd Li Zhijian     2024-03-19  232  		len += sysfs_emit_at(buf, len, "%u ", ddata->gamma[i]);
> > 0688d3b1d882dd Li Zhijian     2024-03-19  233  	if (len)
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  234  		buf[len - 1] = '\n';
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  235
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  236  	return len;
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  237  }
> > f76ee892a99e68 Tomi Valkeinen 2015-12-09  238
> >
> > :::::: The code at line 228 was first introduced by commit
> > :::::: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays for omapfb
> >
> > :::::: TO: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> > :::::: CC: Tomi Valkeinen <tomi.valkeinen@xxxxxx>