On Thu, 21 Mar 2024 23:20:21 +0000 Edward Liaw <edliaw@xxxxxxxxxx> wrote:
> The sigbus-wp test requires the UFFD_FEATURE_WP_HUGETLBFS_SHMEM flag for
> shmem and hugetlb targets. Otherwise it is not backwards compatible
> with kernels <5.19 and fails with EINVAL.
>
> ...
>
> --- a/tools/testing/selftests/mm/uffd-unit-tests.c
> +++ b/tools/testing/selftests/mm/uffd-unit-tests.c
> @@ -1437,7 +1437,8 @@ uffd_test_case_t uffd_tests[] = {
> .uffd_fn = uffd_sigbus_wp_test,
> .mem_targets = MEM_ALL,
> .uffd_feature_required = UFFD_FEATURE_SIGBUS |
> - UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP,
> + UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP |
> + UFFD_FEATURE_WP_HUGETLBFS_SHMEM,
> },
> {
> .name = "events",
Thanks, I'll add
Fixes: 73c1ea939b65 ("selftests/mm: move uffd sig/events tests into uffd unit tests")
Cc: <stable@xxxxxxxxxxxxxxx>
