On Wed, Mar 20, 2024 at 12:34 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > you can expect it to be coherent. > > Fair enough, but don't we still need a barrier there? Couldn't some > initializations still be reorder after zswap_lru_add()? I am under the impression that the lru list handling function already handles the barrier. If an explicit barrier is needed, wouldn't all other lru callers have barriers sprinkling all over the place? Chris