Re: [PATCH] ARM: unwind: improve unwinders for noreturn case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jiangfeng Xiao <xiaojiangfeng@xxxxxxxxxx>
Subject: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Wed, 20 Mar 2024 03:34:04 +0000
Cc: Kees Cook <keescook@xxxxxxxxxxxx>, linux@xxxxxxxxxxxxxxx, arnd@xxxxxxxx, rmk+kernel@xxxxxxxxxxxxxxx, haibo.li@xxxxxxxxxxxx, angelogioacchino.delregno@xxxxxxxxxxxxx, amergnat@xxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, douzhaolei@xxxxxxxxxx, gustavoars@xxxxxxxxxx, jpoimboe@xxxxxxxxxx, kepler.chenxin@xxxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, nixiaoming@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, wangbing6@xxxxxxxxxx, wangfangpeng1@xxxxxxxxxx, jannh@xxxxxxxxxx, David.Laight@xxxxxxxxxx
In-reply-to: <fb8c6e8f-de47-8cbc-e30a-60961f5ce7ad@huawei.com>
References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710901169-22763-1-git-send-email-xiaojiangfeng@huawei.com> <202403191945.661DBCE8@keescook> <fb8c6e8f-de47-8cbc-e30a-60961f5ce7ad@huawei.com>

On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote:
> The checkpatch.pl script reports the "WARNING: printk() should
> include KERN_<LEVEL> facility level" warning.
> 
> That's why I changed printk to pr_warn.
> I should change printk to printk(KERN_DEFAULT).

No, you should ignore checkpatch.  For bonus points, figure out why you
should ignore it specifically in this case.

Follow-Ups:
- Re: [PATCH] ARM: unwind: improve unwinders for noreturn case
  - From: Jiangfeng Xiao

References:
- [PATCH] usercopy: delete __noreturn from usercopy_abort
  - From: Jiangfeng Xiao
- [PATCH] ARM: unwind: improve unwinders for noreturn case
  - From: Jiangfeng Xiao
- Re: [PATCH] ARM: unwind: improve unwinders for noreturn case
  - From: Kees Cook
- Re: [PATCH] ARM: unwind: improve unwinders for noreturn case
  - From: Jiangfeng Xiao

Prev by Date: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case
Next by Date: [RFC PATCH 1/7] sysfs interface for the boundary of movable zone
Previous by thread: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case
Next by thread: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]