This patch adds mm infrastructure support to set and test access bits at different levels of the page table tree. The patch also adds support to check if a give address is in the PMD/PUD/PGD address range. Signed-off-by: Alan Nair <alan.nair@xxxxxxxxx> Signed-off-by: Aravinda Prasad <aravinda.prasad@xxxxxxxxx> --- arch/x86/include/asm/pgtable.h | 20 +++++++++ arch/x86/mm/pgtable.c | 28 +++++++++++- include/linux/mmu_notifier.h | 36 ++++++++++++++++ include/linux/pgtable.h | 79 ++++++++++++++++++++++++++++++++++ 4 files changed, 161 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 7621a5acb13e..b8d505194282 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -164,11 +164,24 @@ static inline bool pud_dirty(pud_t pud) return pud_flags(pud) & _PAGE_DIRTY_BITS; } +#define pud_young pud_young static inline int pud_young(pud_t pud) { return pud_flags(pud) & _PAGE_ACCESSED; } +#define p4d_young p4d_young +static inline int p4d_young(p4d_t p4d) +{ + return p4d_flags(p4d) & _PAGE_ACCESSED; +} + +#define pgd_young pgd_young +static inline int pgd_young(pgd_t pgd) +{ + return pgd_flags(pgd) & _PAGE_ACCESSED; +} + static inline int pte_write(pte_t pte) { /* @@ -1329,10 +1342,17 @@ extern int pudp_set_access_flags(struct vm_area_struct *vma, pud_t entry, int dirty); #define __HAVE_ARCH_PMDP_TEST_AND_CLEAR_YOUNG +#define pudp_test_and_clear_young pudp_test_and_clear_young +#define p4dp_test_and_clear_young p4dp_test_and_clear_young +#define pgdp_test_and_clear_young pgdp_test_and_clear_young extern int pmdp_test_and_clear_young(struct vm_area_struct *vma, unsigned long addr, pmd_t *pmdp); extern int pudp_test_and_clear_young(struct vm_area_struct *vma, unsigned long addr, pud_t *pudp); +extern int p4dp_test_and_clear_young(struct vm_area_struct *vma, + unsigned long addr, p4d_t *p4dp); +extern int pgdp_test_and_clear_young(struct vm_area_struct *vma, + unsigned long addr, pgd_t *pgdp); #define __HAVE_ARCH_PMDP_CLEAR_YOUNG_FLUSH extern int pmdp_clear_flush_young(struct vm_area_struct *vma, diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c index ff690ddc2334..9f8e08326b43 100644 --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -578,9 +578,7 @@ int pmdp_test_and_clear_young(struct vm_area_struct *vma, return ret; } -#endif -#ifdef CONFIG_TRANSPARENT_HUGEPAGE int pudp_test_and_clear_young(struct vm_area_struct *vma, unsigned long addr, pud_t *pudp) { @@ -594,6 +592,32 @@ int pudp_test_and_clear_young(struct vm_area_struct *vma, } #endif +#ifdef CONFIG_ARCH_HAS_NONLEAF_PMD_YOUNG +int p4dp_test_and_clear_young(struct vm_area_struct *vma, + unsigned long addr, p4d_t *p4dp) +{ + int ret = 0; + + if (p4d_young(*p4dp)) + ret = test_and_clear_bit(_PAGE_BIT_ACCESSED, + (unsigned long *)p4dp); + + return ret; +} + +int pgdp_test_and_clear_young(struct vm_area_struct *vma, + unsigned long addr, pgd_t *pgdp) +{ + int ret = 0; + + if (pgd_young(*pgdp)) + ret = test_and_clear_bit(_PAGE_BIT_ACCESSED, + (unsigned long *)pgdp); + + return ret; +} +#endif + int ptep_clear_flush_young(struct vm_area_struct *vma, unsigned long address, pte_t *ptep) { diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h index f349e08a9dfe..ec7fc170882e 100644 --- a/include/linux/mmu_notifier.h +++ b/include/linux/mmu_notifier.h @@ -581,6 +581,39 @@ static inline void mmu_notifier_range_init_owner( __young; \ }) +#define pudp_clear_young_notify(__vma, __address, __pudp) \ +({ \ + int __young; \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + __young = pudp_test_and_clear_young(___vma, ___address, __pudp);\ + __young |= mmu_notifier_clear_young(___vma->vm_mm, ___address, \ + ___address + PUD_SIZE); \ + __young; \ +}) + +#define p4dp_clear_young_notify(__vma, __address, __p4dp) \ +({ \ + int __young; \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + __young = p4dp_test_and_clear_young(___vma, ___address, __p4dp);\ + __young |= mmu_notifier_clear_young(___vma->vm_mm, ___address, \ + ___address + P4D_SIZE); \ + __young; \ +}) + +#define pgdp_clear_young_notify(__vma, __address, __pgdp) \ +({ \ + int __young; \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + __young = pgdp_test_and_clear_young(___vma, ___address, __pgdp);\ + __young |= mmu_notifier_clear_young(___vma->vm_mm, ___address, \ + ___address + PGDIR_SIZE); \ + __young; \ +}) + /* * set_pte_at_notify() sets the pte _after_ running the notifier. * This is safe to start by updating the secondary MMUs, because the primary MMU @@ -690,6 +723,9 @@ static inline void mmu_notifier_subscriptions_destroy(struct mm_struct *mm) #define pmdp_clear_flush_young_notify pmdp_clear_flush_young #define ptep_clear_young_notify ptep_test_and_clear_young #define pmdp_clear_young_notify pmdp_test_and_clear_young +#define pudp_clear_young_notify pudp_test_and_clear_young +#define p4dp_clear_young_notify p4dp_test_and_clear_young +#define pgdp_clear_young_notify pgdp_test_and_clear_young #define ptep_clear_flush_notify ptep_clear_flush #define pmdp_huge_clear_flush_notify pmdp_huge_clear_flush #define pudp_huge_clear_flush_notify pudp_huge_clear_flush diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 85fc7554cd52..09c3e8bb11bf 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -184,6 +184,27 @@ static inline int pmd_young(pmd_t pmd) } #endif +#ifndef pud_young +static inline int pud_young(pud_t pud) +{ + return 0; +} +#endif + +#ifndef p4d_young +static inline int p4d_young(p4d_t p4d) +{ + return 0; +} +#endif + +#ifndef pgd_young +static inline int pgd_young(pgd_t pgd) +{ + return 0; +} +#endif + #ifndef pmd_dirty static inline int pmd_dirty(pmd_t pmd) { @@ -386,6 +407,33 @@ static inline int pmdp_test_and_clear_young(struct vm_area_struct *vma, #endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_ARCH_HAS_NONLEAF_PMD_YOUNG */ #endif +#ifndef pudp_test_and_clear_young +static inline int pudp_test_and_clear_young(struct vm_area_struct *vma, + unsigned long address, + pud_t *pudp) +{ + return 0; +} +#endif + +#ifndef p4dp_test_and_clear_young +static inline int p4dp_test_and_clear_young(struct vm_area_struct *vma, + unsigned long address, + p4d_t *p4dp) +{ + return 0; +} +#endif + +#ifndef pgdp_test_and_clear_young +static inline int pgdp_test_and_clear_young(struct vm_area_struct *vma, + unsigned long address, + pgd_t *pgdp) +{ + return 0; +} +#endif + #ifndef __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH int ptep_clear_flush_young(struct vm_area_struct *vma, unsigned long address, pte_t *ptep); @@ -1090,6 +1138,37 @@ static inline void arch_swap_restore(swp_entry_t entry, struct folio *folio) #define flush_tlb_fix_spurious_fault(vma, address, ptep) flush_tlb_page(vma, address) #endif +/* + * When walking page tables, get the address of the current boundary, + * or the start address of the range if that comes earlier. + */ + +#define pgd_addr_start(addr, start) \ +({ unsigned long __boundary = (addr) & PGDIR_MASK; \ + (__boundary > start) ? __boundary : (start); \ +}) + +#ifndef p4d_addr_start +#define p4d_addr_start(addr, start) \ +({ unsigned long __boundary = (addr) & P4D_MASK; \ + (__boundary > start) ? __boundary : (start); \ +}) +#endif + +#ifndef pud_addr_start +#define pud_addr_start(addr, start) \ +({ unsigned long __boundary = (addr) & PUD_MASK; \ + (__boundary > start) ? __boundary : (start); \ +}) +#endif + +#ifndef pmd_addr_start +#define pmd_addr_start(addr, start) \ +({ unsigned long __boundary = (addr) & PMD_MASK; \ + (__boundary > start) ? __boundary : (start); \ +}) +#endif + /* * When walking page tables, get the address of the next boundary, * or the end address of the range if that comes earlier. Although no -- 2.21.3