On Mon, Mar 11, 2024 at 3:06 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > > > + arena_vm_start = bpf_arena_get_kern_vm_start(bpf_prog->aux->arena); > > and I'm guessing here you didn't want that check... I'd probably go > with explicit pointer checks, but ok, it's fine It's not only here. I expect all JITs will be calling it and explicit NULL check will be replicated. Hence I went with a NULL check inside that helper. Another reason is: __weak u64 bpf_arena_get_*() { return 0; } So simple code overall.