All zswap backends track their pool sizes in pages. Currently they multiply by PAGE_SIZE for zswap, only for zswap to divide again in order to do limit math. Report pages directly. Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> --- mm/z3fold.c | 2 +- mm/zbud.c | 2 +- mm/zpool.c | 4 ++-- mm/zsmalloc.c | 2 +- mm/zswap.c | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 7ab05621052d..9bacacd4168c 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -1404,7 +1404,7 @@ static void z3fold_zpool_unmap(void *pool, unsigned long handle) static u64 z3fold_zpool_total_size(void *pool) { - return z3fold_get_pool_size(pool) * PAGE_SIZE; + return z3fold_get_pool_size(pool); } static struct zpool_driver z3fold_zpool_driver = { diff --git a/mm/zbud.c b/mm/zbud.c index 2190cc1f37b3..b7d8a22bbf5f 100644 --- a/mm/zbud.c +++ b/mm/zbud.c @@ -412,7 +412,7 @@ static void zbud_zpool_unmap(void *pool, unsigned long handle) static u64 zbud_zpool_total_size(void *pool) { - return zbud_get_pool_size(pool) * PAGE_SIZE; + return zbud_get_pool_size(pool); } static struct zpool_driver zbud_zpool_driver = { diff --git a/mm/zpool.c b/mm/zpool.c index 846410479c2f..410808aee7fe 100644 --- a/mm/zpool.c +++ b/mm/zpool.c @@ -324,9 +324,9 @@ void zpool_unmap_handle(struct zpool *zpool, unsigned long handle) * zpool_get_total_size() - The total size of the pool * @zpool: The zpool to check * - * This returns the total size in bytes of the pool. + * This returns the total size in pages of the pool. * - * Returns: Total size of the zpool in bytes. + * Returns: Total size of the zpool in pages. */ u64 zpool_get_total_size(struct zpool *zpool) { diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 7d7cb3eaabe0..398f3856817f 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -401,7 +401,7 @@ static void zs_zpool_unmap(void *pool, unsigned long handle) static u64 zs_zpool_total_size(void *pool) { - return zs_get_total_pages(pool) << PAGE_SHIFT; + return zs_get_total_pages(pool); } static struct zpool_driver zs_zpool_driver = { diff --git a/mm/zswap.c b/mm/zswap.c index 7c39327a7cc2..fe4343e416e0 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -507,7 +507,7 @@ static unsigned long zswap_max_pages(void) unsigned long zswap_total_pages(void) { struct zswap_pool *pool; - u64 total = 0; + unsigned long total = 0; rcu_read_lock(); list_for_each_entry_rcu(pool, &zswap_pools, list) { @@ -518,7 +518,7 @@ unsigned long zswap_total_pages(void) } rcu_read_unlock(); - return total >> PAGE_SHIFT; + return total; } /********************************* -- 2.44.0