* Elliot Berman <quic_eberman@xxxxxxxxxxx> [2024-02-22 15:16:33]: > Add ioctl to trigger the start of a Gunyah virtual machine. Subsequent > commits will provide memory to the virtual machine and add ability to > interact with the resources (capabilities) of the virtual machine. > Although start of the virtual machine can be done implicitly on the > first vCPU run for proxy-schedule virtual machines, there is a > non-trivial number of calls to Gunyah: a more precise error can be given > to userspace which calls VM_START without looking at kernel logs because > userspace can detect that the VM start failed instead of "couldn't run > the vCPU". > > Co-developed-by: Prakruthi Deepak Heragu <quic_pheragu@xxxxxxxxxxx> > Signed-off-by: Prakruthi Deepak Heragu <quic_pheragu@xxxxxxxxxxx> > Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx> Minor nit below. LGTM otherwise. Reviewed-by: Srivatsa Vaddagiri <quic_svaddagi@xxxxxxxxxxx> > +static int gunyah_vm_start(struct gunyah_vm *ghvm) > +{ .. > +err: > + /* gunyah_vm_free will handle releasing resources and reclaiming memory */ s/gunyah_vm_free/gunyah_vm_release > + up_write(&ghvm->status_lock); > + return ret; > +}