On Tue, 2024-03-05 at 21:15 +0800, kernel test robot wrote: > > > > ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c- > > > core.ko] undefined! > My recent change introduced a build failure when building as a module. ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko] undefined! I think the issue is that I called acpi_device_notify_remove() which is not exported (i.e. no EXPORT_SYMBOL_GPL). I'm not sure if the correct fix is to mark acpi_device_notify_remove() as exported (my gut says no), or to instead modify my new code to call the already exported acpi_unbind_one() - acpi_unbind_one() is already exported. I was only calling acpi_device_notify_remove() to trigger acpi_unbind_one() anyway, so that seems like what I should do. Please let me know which fix is preferred and I will prepare a fix to the original patch. Thanks, Hamish M
